Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Use high GD frequency on nRF54H20 #20469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarekPieta
Copy link
Contributor

@MarekPieta MarekPieta commented Feb 18, 2025

In nRF Desktop application, the DVFS module running on the application core selects clock control and enables automatic low GD frequency request. Update IPC radio configuration to ensure high GD frequency, which is required to ensure stability of the Bluetooth stack with SoftDevice Link Layer.

Jira: NCSDK-31824

@MarekPieta MarekPieta requested a review from a team as a code owner February 18, 2025 15:00
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 18, 2025
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 18, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 399aeca0e88cdc04070023662a7f0ec82bd1bf15

more details

sdk-nrf:

PR head: 399aeca0e88cdc04070023662a7f0ec82bd1bf15
merge base: ae518d055670fcca964fbe0f10809a4dd4481e8b
target head (main): ae518d055670fcca964fbe0f10809a4dd4481e8b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54h20dk_nrf54h20_cpurad
│  │  │  │  ├── images
│  │  │  │  │  ├── ipc_radio
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │ prj_release.conf
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 72
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@pdunaj pdunaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @ppryga-nordic .
one question - if this is required why this is not a default option?

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 19, 2025
@MarekPieta MarekPieta requested a review from a team as a code owner February 19, 2025 07:42
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 19, 2025
@MarekPieta MarekPieta changed the title applications: nrf_desktop: Use high GDFS frequency on nRF54H20 applications: nrf_desktop: Use high GD frequency on nRF54H20 Feb 19, 2025
Copy link

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20469/nrf/releases_and_maturity/releases/release-notes-changelog.html

@ppryga-nordic
Copy link
Contributor

thanks, @ppryga-nordic . one question - if this is required why this is not a default option?

That is more complex. In essence that should not be used at all, I'm going to add a runtime request to MPSL. The option, as I was told, was provided as optimization for some (don't know which) application, to avoid immediate request to high frequency during boot process and then releasing it back.
How the workaround is done is another topic. If that was an option that "disables" the initial low frequency request set by default to n, then it could be selected by BT_LL_SOFTDEVICE.

@MarekPieta MarekPieta requested a review from peknis February 20, 2025 10:37
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor nit.

In nRF Desktop application, the DVFS module running on the application
core selects clock control and enables automatic low GD frequency
request. Update IPC radio configuration to ensure high GD frequency,
which is required to ensure stability of the Bluetooth stack with
SoftDevice Link Layer.

Jira: NCSDK-31824

Signed-off-by: Marek Pieta <[email protected]>
Signed-off-by: Piotr Pryga <[email protected]>
Signed-off-by: Pekka Niskanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants