Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nx-dev): make toc sticky #29784

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(nx-dev): make toc sticky #29784

merged 1 commit into from
Jan 28, 2025

Conversation

isaacplmann
Copy link
Collaborator

Makes sidebar table of contents not overlap the footer

Fixes #29719

@isaacplmann isaacplmann requested a review from a team as a code owner January 28, 2025 17:16
@isaacplmann isaacplmann requested a review from jaysoo January 28, 2025 17:16
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 28, 2025 5:25pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b03b349.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 5m 40s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 13s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=82c4e... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 17:25:39 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025

View your CI Pipeline Execution ↗ for commit b03b349.

Command Status Duration Result
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 17:18:59 UTC

@isaacplmann isaacplmann merged commit 67f12a2 into master Jan 28, 2025
5 checks passed
@isaacplmann isaacplmann deleted the nx-dev/sticky-toc branch January 28, 2025 18:43
FrozenPandaz pushed a commit that referenced this pull request Jan 28, 2025
@isaacplmann @FrozenPandaz
fix(nx-dev): make toc sticky (#29784)
66eabff 
Makes sidebar table of contents not overlap the footer

Fixes #29719

(cherry picked from commit 67f12a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaysoo jaysoo jaysoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@isaacplmann @jaysoo