fix(ci): replace invalid Actions pin with the commit SHA it resolves to - #36533
Open
MGPOCKY wants to merge 1 commit into
Open
fix(ci): replace invalid Actions pin with the commit SHA it resolves to#36533MGPOCKY wants to merge 1 commit into
MGPOCKY wants to merge 1 commit into
Conversation
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
These workflow
uses:pins are invalid as written. Each item below shows the current value, why it is wrong, and the correct ref that must be used instead.1.
.github/workflows/ci.ymlCurrent (invalid):
Why this is wrong:
48b5f213c81028ace310571dc5ec0fbbca0b2947is not a commit SHA. It is the Git object SHA of an annotated tag (v4.4.3).uses:pins (Commits API returnsNo commit found for SHA).v4.4.3points to:ed408507eac070d1f99cc633dbcf757c94c7933a.Correct pin:
2.
.github/workflows/e2e-matrix.ymlCurrent (invalid):
Why this is wrong:
1fb8b1023602bf1fd0e2994d7f1e93015cb5bbecis not a commit SHA. It is the Git object SHA of an annotated tag (v3.22).uses:pins (Commits API returnsNo commit found for SHA).v3.22points to:7b6a61a73bbb9793cb80ad69b8dd8ac19261834c.Correct pin:
3.
.github/workflows/generate-embeddings.ymlCurrent (invalid):
Why this is wrong:
7088e561eb65bb68695d245aa206f005ef30921dis not a commit SHA. It is the Git object SHA of an annotated tag (v4.1.0).uses:pins (Commits API returnsNo commit found for SHA).v4.1.0points to:a7487c7e89a18df4991f7f222e4898a00d66ddda.Correct pin:
4.
.github/workflows/issue-notifier.ymlCurrent (invalid):
Why this is wrong:
7088e561eb65bb68695d245aa206f005ef30921dis not a commit SHA. It is the Git object SHA of an annotated tag (v4.1.0).uses:pins (Commits API returnsNo commit found for SHA).v4.1.0points to:a7487c7e89a18df4991f7f222e4898a00d66ddda.Correct pin:
5.
.github/workflows/publish.ymlCurrent (invalid):
Why this is wrong:
462ed697694d2ac9aa49e1225f395f7bb6dd49feis not a commit SHA. It is the Git object SHA of an annotated tag (v0.29.0).uses:pins (Commits API returnsNo commit found for SHA).v0.29.0points to:e8a7b572196ff79ded1979dc2bb9ee67d1ddb252.Correct pin:
Test plan
uses:ref resolves as a commit via the GitHub Commits API