Skip to content

fix(core): raise the nx package vitest timeout to cover the graph recompute spec - #36850

Merged
AgentEnder merged 1 commit into
masterfrom
fix/nx-vitest-test-timeout
Aug 30, 2026
Merged

fix(core): raise the nx package vitest timeout to cover the graph recompute spec#36850
AgentEnder merged 1 commit into
masterfrom
fix/nx-vitest-test-timeout

Conversation

@AgentEnder

Copy link
Copy Markdown
Member

Current Behavior

project-graph-incremental-recomputation.spec.ts times out at exactly 35,000ms on CI on every run that executes it. Three consecutive runs on one branch clipped at 35,009ms, 35,018ms and 35,070ms on the same test. Master rarely shows it: most commits do not touch packages/nx, so nx:test is served from cache, and 9 of the last 12 master commits never ran the spec.

Expected Behavior

The spec has enough budget to finish on CI hardware. With the limit raised for measurement, the slowest test needs 42.4s and its neighbours land at 32s and 29s; the whole suite went green with no other change. Locally the same test swings between 7s and 23s depending on pool load, so a 35s ceiling sits inside the spec's own variance once CI's roughly 5x slowdown is applied. 90s clears the measured worst case by 2x.

This is not a vitest transform regression: the jest preset carried the same 35s before #36754.

Related Issue(s)

Unblocks #36838, which is stacked on this branch and will be retargeted to master once this merges.

…ompute spec

project-graph-incremental-recomputation.spec.ts times out at exactly
35000ms on CI on every run that actually executes it: three runs in a row
clipped at 35,009 / 35,018 / 35,070ms. Measured with the limit raised, the
slowest test needs 42.4s on CI hardware, and its neighbours land at 32s
and 29s. Locally the same test swings between 7s and 23s depending on
pool load, so a 35s ceiling is inside the spec's own variance once CI's
roughly 5x slowdown is applied.

Master rarely shows it because most commits do not touch packages/nx and
nx:test is served from cache. Any branch that busts that cache runs the
spec every push and hits the limit.

The jest preset carried the same 35s before the vitest move, so this is
not a transform regression; the spec has been close to the line for a
while and only surfaces on branches that execute it repeatedly.
@AgentEnder
AgentEnder requested a review from a team as a code owner August 30, 2026 03:02
@AgentEnder
AgentEnder requested a review from MaxKless August 30, 2026 03:02
@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 62c3e5e
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6a939d65d042530008347b00
😎 Deploy Preview https://deploy-preview-36850--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 62c3e5e
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6a939d662964f2000810192b
😎 Deploy Preview https://deploy-preview-36850--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 62c3e5e

Command Status Duration Result
nx affected --targets=lint,oxlint,test,build,e2... ✅ Succeeded 55m 4s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 56s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 19s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-30 04:02:24 UTC

@AgentEnder
AgentEnder merged commit ce2ff7f into master Aug 30, 2026
25 checks passed
@AgentEnder
AgentEnder deleted the fix/nx-vitest-test-timeout branch August 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants