fix(release): stage deleted version plans on Windows - #36854
Open
mturac wants to merge 1 commit into
Open
Conversation
… files On Windows, path.join produces backslash-separated paths for version plan files (.nx\version-plans\file.md), but git status --porcelain always returns forward slashes. The Set.has() lookup in gitAdd failed to match, so deleted version plans were never staged. Normalize backslash separators to forward slashes before the comparison and staging step.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36792 —
nx release changelogdeletes applied version plans but does not stage the deletion on Windows, leaving the removed files as uncommitted changes.Root cause:
plan.relativePathis built with Node'spath.join, which produces backslash-separated paths on Windows (.nx\version-plans\file.md). ThegitAddfunction compares deleted file paths againstgit status --porcelainoutput, which always uses forward slashes (.nx/version-plans/file.md). TheSet.has()lookup fails because the separators don't match, so the deleted file is never added to the staging list.Fix: Normalize backslash separators to forward slashes in the
deletedFilesloop insidegitAdd, before theisIgnoredcheck and thechangedTrackedFiles.has()lookup. Forward-slash paths are passed togit add, which accepts them on all platforms.Changed files
packages/nx/src/command-line/release/utils/git.ts— normalize\to/indeletedFilespaths before comparison and stagingpackages/nx/src/command-line/release/utils/git-add.spec.ts— regression test: backslash-separated deleted file path is normalized and stagedTest plan
tsc --noEmiton changed files — no errors