fix(core): release per-run process listeners and task history results - #36866
Open
AgentEnder wants to merge 1 commit into
Open
fix(core): release per-run process listeners and task history results#36866AgentEnder wants to merge 1 commit into
AgentEnder wants to merge 1 commit into
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 33b55c8
☁️ Nx Cloud last updated this comment at |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@23.2.0-pr.36866.449f6f3 my-workspaceOr just copy this version and use it in your own command: 23.2.0-pr.36866.449f6f3
To request a new release for this pull request, mention someone from the Nx team or the |
meeroslav
approved these changes
Sep 1, 2026
AgentEnder
force-pushed
the
vf-leak-9df6a131
branch
4 times, most recently
from
September 1, 2026 22:28
3ce7fc7 to
12868de
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
The DTE agent path creates a TaskOrchestrator per runDiscreteTasks call in one long-lived process. Each orchestrator registered SIGINT/SIGTERM/SIGHUP handlers (plus the forked runner's message/exit handlers) that closed over the orchestrator and were never removed, pinning the task hasher (including the native project-graph copy), lifecycles, and every TaskResult with its full terminalOutput — showing up as unbounded RSS growth on Nx Cloud agents (~1x each task's stdout plus per-batch fixed costs, permanently, per assignment batch). - TaskOrchestrator.dispose() removes the signal handlers and the forked runner's process listeners; called at the end of run(), after runDiscreteTasks results settle, and after continuous tasks exit - TaskHistoryLifeCycle.pendingResults (a process-lifetime singleton) no longer retains terminalOutput and is cleared in endCommand()
AgentEnder
force-pushed
the
vf-leak-9df6a131
branch
from
September 2, 2026 21:38
b36907e to
33b55c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Every
runDiscreteTaskscall registers SIGINT/SIGTERM/SIGHUP handlers (plus the forked runner's message/exit handlers) that are never removed. Each closes over its orchestrator, so a long-lived process like an Nx Cloud agent retains every orchestrator it ever created: the task hasher (with its native project-graph copy), the lifecycles, and every task result with full terminal output.TaskHistoryLifeCycle.pendingResultsalso keeps everyTaskResultfor the life of the process. A profiled customer agent grew from 237MB to 5.5GB over 50 tasks.Expected Behavior
Process listeners are removed once a run completes, task history stops retaining terminal output, and agent memory stays flat across assignment batches.
Related Issue(s)
Fixes #
View Polygraph session ↗