feat(core): report abandoned, revisited and resumed orchestrated migrate runs and their dispense ordinals - #36989
Draft
leosvelperez wants to merge 2 commits into
Draft
feat(core): report abandoned, revisited and resumed orchestrated migrate runs and their dispense ordinals#36989leosvelperez wants to merge 2 commits into
leosvelperez wants to merge 2 commits into
Conversation
leosvelperez
added this pull request to stack #36919
September 10, 2026 13:15
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit bb56465
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
leosvelperez
force-pushed
the
nxc-4818
branch
from
September 10, 2026 15:48
3cede9d to
c79a9de
Compare
leosvelperez
force-pushed
the
nxc-4818
branch
from
September 10, 2026 16:37
c79a9de to
cae1a71
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ate runs and their dispense ordinals An orchestrated migrate run spans many short-lived nx processes driven by an agent that can stop calling nx at any point. Nothing ran at the end to say the run was abandoned, so abandonment only showed up as a missing migrate_orchestrator_complete. The classic loop never had this gap: one process emits both its start and its end. A run id dimension was the original plan and was dropped: the GA property has no BigQuery export, so an undeclared parameter is unreadable, and GA advises against declaring unique ids as dimensions (past ~500 distinct values a day they collapse into an "(other)" row). The signals below need no new dimension and no Rust change. - migrate_orchestrator_abandoned: the spawn-path parent reads run.json after the agent exits; a run still active at that point is reported with the same tallies complete carries (applied, skipped, dispense count) plus the agent id. Exact per-run abandonment for user-initiated runs. - migrate_orchestrator_existing_run: every existing-run report, whether init printed it for the agent or handed it to the master session. On the master path it precedes the resume when the user continues; on the agent path it is the only trace of a revisit. - migrate_orchestrator_resume: every resume reports the same tallies, which the start watermark hid until now. The state cannot tell a crashed session from a re-invocation, so both count. A bare --run-id reconcile is not a resume: nothing in run state marks the first call after a lost session. - migrate_orchestrator_step_dispensed: once per durable dispense transition, carrying the run-wide dispense ordinal on task_count. Counting it per ordinal is the survival curve for agent-initiated runs, which have no parent process to observe them. - migrate_orchestrator_dispense gains the same ordinal. It repeats on every reconcile until the step moves, so it feeds the action mix per position, not the curve. runTallies() in state-machine.ts derives the event tallies from tallySteps() so the completion event and the new events agree with the completion summary on one step classification; adopted steps count as completed. Classic single-process events are unchanged.
leosvelperez
force-pushed
the
nxc-4818
branch
from
September 10, 2026 19:41
cae1a71 to
bb56465
Compare
…ate runs and their dispense ordinals [Self-Healing CI Rerun]
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
This only applies to orchestrated migrate runs, behind
NX_MIGRATE_ORCHESTRATOR.An orchestrated run is many short nx calls driven by an agent. The agent can stop calling nx at any point. Nothing runs at the end to say so. In analytics an abandoned run only shows up as a start event with no completion event. The classic loop never had this gap, because one process sends both its start and its end.
When a session continues an existing run, or finds one and reports it, analytics sees nothing either. The start event is sent once per run, so a restarted session leaves no trace.
Expected Behavior
Analytics can tell how orchestrated runs end and how far they got. Every event below carries the run's tallies: applied, skipped, and steps handed out.
Related Issue(s)
NXC-4818
Implementation Notes
migrate_orchestrator_step_dispensedfires once per durable step handout and is the curve.runTallies()instate-machine.tsderives the event tallies fromtallySteps(), so the completion summary, the completion event and the new events share one step classification. Adopted steps count as applied.--run-idis not a resume: nothing in run state marks the first call after a lost session.