Use WindowInsetsCompat for navigation bar height#12
Open
latidoremi wants to merge 1 commit intonschairer:mainfrom
Open
Use WindowInsetsCompat for navigation bar height#12latidoremi wants to merge 1 commit intonschairer:mainfrom
latidoremi wants to merge 1 commit intonschairer:mainfrom
Conversation
Author
|
I also tuned down the threadshold that triggers the event, when using the google Gboard voice typing mode, you can half collapse the keyboard and the keyboard height can get pretty low, 0.15 is too high for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNavigationBarHeight()andisNavigationBarVisible()can return incorrect values on some devices in gesture navigation mode, leading to wrong keyboard height calculationOn the Huawei v40 lite I have:
Gesture navigation + indicator bar disabled
Gesture navigation + indicator bar enabled
Button navigation
I propose switching to WindowInsetsCompat to retrieve the navigation bar height:
This returns the correct values on all devices I tested (Huawei V40 Lite, Redmi K70, Samsung S9)
This may also fix #11