Recreate lost EC parts #3628
Open
Recreate lost EC parts #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
ec-part-recreation
branch
3 times, most recently
from
2cde16f to
bedbf70
Compare
cthulhu-rider
force-pushed
the
ec-part-recreation
branch
6 times, most recently
from
1263882 to
7d18369
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3628 +/- ##
==========================================
+ Coverage 26.97% 27.01% +0.04%
==========================================
Files 656 656
Lines 51273 51785 +512
==========================================
+ Hits 13831 13990 +159
- Misses 36380 36723 +343
- Partials 1062 1072 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extend `Policer` with workers checking availability of EC parts. Free worker takes the job each time some EC part is processed by regular Policer routine. If no more than N parts are unavailable (where N is a number of parity parts in the container policy), they are recreated using available ones. Recreated object has the same ID but signed by SN itself. To ensure such objects are accepted, the corresponding checks are relaxed for EC parts. Closes #3554. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
ec-part-recreation
branch
from
7d18369 to
453ddf1
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
added a commit
that referenced
this pull request
Oct 24, 2025
The session token is in the parent object, but in the part it is meaningless. Moreover, if the part object needs to be recreated, the session token will no longer exist. Therefore, not adding a token preserves the object ID which is good for deduplication. For this to work, it was necessary to make an exception when checking the signature against the object owner. Refs #3628. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
that referenced
this pull request
Oct 24, 2025
The session token is in the parent object, but in the part it is meaningless. Moreover, if the part object needs to be recreated, the session token will no longer exist. Therefore, not adding a token preserves the object ID which is good for deduplication. For this to work, it was necessary to make an exception when checking the signature against the object owner. Refs #3628. Signed-off-by: Leonard Lyubich <[email protected]>
|
lets handle #3651 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.