Skip to content

EC proxy #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

EC proxy #3654

merged 2 commits into from
Oct 31, 2025

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Oct 27, 2025 •
edited
Loading

@evgeniiz321 pls try this

@cthulhu-rider
sn/object: Abort GET/HEAD/RANGE in EC containers on access error
1ab8419 
There is no point in continuing the operation with such an error.
Returning it will make it easier to find the problem.

Refs #3422, #3423, #3614.

Signed-off-by: Leonard Lyubich <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 8.62069% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.37%. Comparing base (3c2b016) to head (4eee4e4).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/get/get.go 6.66% 27 Missing and 1 partial ⚠️
pkg/services/object/get/util.go 0.00% 14 Missing ⚠️
pkg/services/object/get/ec.go 21.42% 11 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3654   +/-   ##
=======================================
  Coverage   27.36%   27.37%           
=======================================
  Files         656      656           
  Lines       41176    41239   +63     
=======================================
+ Hits        11268    11289   +21     
- Misses      28851    28893   +42     
  Partials     1057     1057

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review October 28, 2025 08:25
@cthulhu-rider cthulhu-rider added bug Something isn't working neofs-storage Storage node application issues labels Oct 28, 2025
@cthulhu-rider cthulhu-rider added this to the v0.50.0 milestone Oct 28, 2025
@cthulhu-rider cthulhu-rider marked this pull request as draft October 30, 2025 10:33
cthulhu-rider added a commit that referenced this pull request Oct 30, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
2a2e90d 
Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this pull request Oct 30, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
2e48f09 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this pull request Oct 30, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
28f52ea 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this pull request Oct 30, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
0d27034 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review October 30, 2025 11:06
carpawell
carpawell approved these changes Oct 30, 2025
View reviewed changes
@cthulhu-rider cthulhu-rider mentioned this pull request Oct 30, 2025
Open
@carpawell carpawell mentioned this pull request Oct 30, 2025
Merged
cthulhu-rider added a commit that referenced this pull request Oct 30, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
297a138 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
carpawell
carpawell requested changes Oct 30, 2025
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://rest.fs.neo.org/Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/4265-1761836712/index.html#suites/88281b571957371013039835abd59035/1289a959591580a5/

@cthulhu-rider
sn/object: Proxy EC GET/HEAD/RANGE requests when needed
4eee4e4 
When processing EC request, new requests to remote nodes are always
created. The server may not have read permissions for the container
data, so these calls will be forbidden. To avoid this, original request
should be forwarded to the container nodes, as is done for REP rules.

Refs #3422, #3423, #3614.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider
Copy link
Contributor Author

cthulhu-rider commented Oct 31, 2025

fixed https://rest.fs.neo.org/Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/4271-1761845958/index.html

cthulhu-rider added a commit that referenced this pull request Oct 31, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
4bc1a6e 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider merged commit a335424 into master Oct 31, 2025
18 of 21 checks passed
@cthulhu-rider cthulhu-rider deleted the bugfix/ec-forwarding branch October 31, 2025 11:29
cthulhu-rider added a commit that referenced this pull request Oct 31, 2025
@cthulhu-rider
sn/object: Initial support for erasure coding policies by HASH server
c50163a 
Closes #3656. Refs #3423, #3654, #526.

Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carpawell carpawell carpawell approved these changes

@End-rey End-rey End-rey approved these changes

@evgeniiz321 evgeniiz321 Awaiting requested review from evgeniiz321

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees

No one assigned

Labels

bug Something isn't working neofs-storage Storage node application issues

Projects

None yet

Milestone

v0.50.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cthulhu-rider @carpawell @End-rey