Skip to content

Handle search/hash URL components and custom app locations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gadenbuie wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Handle search/hash URL components and custom app locations #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
63895b0
buildignore inst/tmp/
gadenbuie Jun 1, 2020
72a9b39
Remove inst/tmp files
gadenbuie Jun 2, 2020
16f302b
Maintain search params and hash components of URL
gadenbuie Jun 2, 2020
b842737
Document paths(), export paths(), blaze() and as_path() S3 methods
gadenbuie Jun 2, 2020
248d965
Bump dev version, update authors
gadenbuie Jun 2, 2020
c525610
Remove search and hash components of URL when sending browser state u…
gadenbuie Jun 2, 2020
733d41a
Update documentation to use roxygen function links
gadenbuie Jun 2, 2020
e9ee710
Fix function signature of .onLoad() to appease R CMD check
gadenbuie Jun 2, 2020
01aa30b
Adds {utils} to dependencies for packageVersion()
gadenbuie Jun 2, 2020
13a3a14
Unexport param(), it's not ready yet
gadenbuie Jun 2, 2020
c355ff7
Add at least one basic test
gadenbuie Jun 2, 2020
56ba9dc
Don't update path if same as current, also send updates back to server
gadenbuie Jun 2, 2020
d2b70aa
Add app_path argument to paths()
gadenbuie Jun 8, 2020
1019a39
Redirect pages need to redirect to /app_path
gadenbuie Jun 8, 2020
e8b168c
Ensure that getPath() returns "/" when app_path is set
gadenbuie Jun 8, 2020
8d0c7cd
Prepend app_path after checking path input in pushPath
gadenbuie Jun 8, 2020
249eaae
Add path_app() and ensure pathLink() respects global app_path
gadenbuie Jun 8, 2020
7938bf2
Reset app_path if app_path = NULL when calling paths() in same session
gadenbuie Jun 8, 2020
99a4265
observePath() correctly handles leading route path slash
gadenbuie Jun 8, 2020
e8da98d
Add option to push or replace path in pushPath()
gadenbuie Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ S3method(as_paths,yml)
export(blaze)
export(getPath)
export(observePath)
export(param)
export(pathLink)
export(paths)
export(pushPath)
Expand Down
2 changes: 0 additions & 2 deletions R/url.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ mask_params <- function(path, url) {
})
}

#' @rdname observePath
#' @export
Copy link
Owner

@nteetor nteetor Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the function does nothing at the moment. This is a change I especially want to exclude from a feature pull request.

param <- function(x, params = peek_params()) {
sym_x <- rlang::ensym(x)
name_x <- rlang::as_name(sym_x)
Expand Down
3 changes: 0 additions & 3 deletions man/observePath.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/app-002.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ shinyApp(

observePath("/explore/:animal", {
state$explore <- div(
h5("Explore", param("animal"))
h5("Explore", blaze:::param("animal"))
)
})

Expand Down