Add uniform baseplate option to Gridfinity calculator#17
Merged
Conversation
Introduces a 'prefer uniform baseplates' option to the Gridfinity calculator, allowing users to generate layouts with maximally uniform baseplate sizes when possible. Updates context, settings, and calculation logic to support this feature, and adds tests to verify correct behavior and edge cases.
Updated uniform baseplate calculation to avoid creating 1xN or Nx1 baseplates by enforcing a minimum size of 2x2. The selection now prefers solutions with fewer baseplate variants, even if it means slightly less coverage. Added and updated tests to verify these constraints and preferences.
PR Quality Report 📊
|
Updated all useGridfinityCalculation test cases to include the preferUniformBaseplates property in the options object. This ensures tests remain consistent with the updated hook interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add "Prefer uniform baseplate sizes" toggle that allows users to optimize for uniform baseplate dimensions instead of mixed sizes. The feature intelligently
avoids creating impractical 1xN baseplates by enforcing a minimum size of 2x2 grids.
Type of Change
Related Issue
Implements user request for uniform baseplate option
Changes Made
Testing
Test Results:
Screenshots
Feature adds a new toggle "Prefer uniform baseplate sizes" in the Bin Options panel

Checklist