Choose the Linux kernel based on the chosen monitor#50
Merged
Conversation
If the user specifies a specific monitor for the contianer (e.g. Firecracker), then bunny should inlcude the respective kernel image for that monitor. Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk>
There was a problem hiding this comment.
Pull request overview
Selects the default Linux kernel image based on the requested monitor (qemu vs firecracker) when the user does not provide a kernel binary in a containerfile-style build.
Changes:
- Split the single
defaultKernelImageconstant intodefaultQemuKernelImageanddefaultFirecrackerKernelImage. - In
containerfileToPack, choose the kernel source image based on thecom.urunc.unikernel.hypervisorannotation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+199
to
+202
| if instr.Annots["com.urunc.unikernel.hypervisor"] == "qemu" { | ||
| aCopy.SrcState = llb.Image(defaultQemuKernelImage) | ||
| } else { | ||
| aCopy.SrcState = llb.Image(defaultFirecrackerKernelImage) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user specifies a specific monitor for the contianer (e.g. Firecracker), then bunny should inlcude the respective kernel image for that monitor.