Add kv state store#5
Draft
nubskr wants to merge 8 commits into
Draft
Conversation
This PR enhances the `visualize_throughput.py` script by adding a thread scaling visualization mode that enables you to analyze and compare benchmark performance across different thread counts, addressing the gap where Walrus supports thread scaling tests via make bench-scaling but previously lacked visualization tools for this data. The new --mode scaling option provides a dual-axis plot displaying both throughput (writes/second) and bandwidth (MB/s), overlaid with a perfect linear scaling reference line to easily identify scaling efficiency and bottlenecks, along with automatic computation of scaling efficiency percentages, speedup ratios, and detailed comparative metrics presented in both an on-plot statistics box and console summary. I kept in mind that the implementation maintains full backward compatibility with existing real-time monitoring functionality while adding flexible input handling through the `--thread-files` argument that accepts multiple CSV files in `THREADS:FILE` format, export capability via the `--output` flag for generating publication-ready plots.
Add thread scaling visualization to benchmark script in Walrus.
Track per topic cleanliness without expensive syscalls in hot path
nubskr
force-pushed
the
master
branch
5 times, most recently
from
ce420fa to
3e8f385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.