Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cppy upgrade to 1.3.0 to fix linking issues on windows #189

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

MatthieuDartiailh
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (16735f9) to head (b10f5ff).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (16735f9) and HEAD (b10f5ff). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (16735f9) HEAD (b10f5ff)
unittests 15 10
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   87.88%   79.81%   -8.08%     
==========================================
  Files          24       24              
  Lines        1635     1635              
  Branches       84      241     +157     
==========================================
- Hits         1437     1305     -132     
  Misses        184      184              
- Partials       14      146     +132     

@lysnikolaou
Copy link
Contributor

@MatthieuDartiailh Could we go ahead and merge this so that I can rebase onto it in the branch with the changes related to CI for free-threading?

@MatthieuDartiailh
Copy link
Member Author

I am just waiting for https://github.com/nucleic/kiwi/actions/runs/12049797611 to finish and I will merge.

@lysnikolaou
Copy link
Contributor

Perfect, thanks!

@MatthieuDartiailh
Copy link
Member Author

Code coverage drops comes from improve tracking of partial coverage for untestable error branches in the bindings (fail to create a type object...) So everything is fine.

@MatthieuDartiailh MatthieuDartiailh merged commit 24d3b2e into main Nov 27, 2024
18 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the cppy-upgrade branch November 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants