Skip to content

[EPIC] Infractions #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

[EPIC] Infractions #318

wants to merge 35 commits into from

Conversation

@cygnusv
Copy link
Member

@cygnusv cygnusv commented Aug 26, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

theref and others added 30 commits August 20, 2024 13:41
@theref
Add first draft of InfractionCollector
ecb747c 
Fixes #266
@theref
Replace reference to adjudicator in TACoChildApplication with `in…
9e7e0e9 
…fractionCollector`

Fix formatting errors and tests

Include Participant struct

Fix types

Fix test reversion message
@theref @cygnusv
Set Coordinator and TACoChild contracts to be public
db0d7ce 
Co-authored-by: David Núñez <[email protected]>
@theref
Add FAILING tests for infraction collector
bca6b8a
@theref
Get first InfractionCollector test passing
94b69ef
@theref
Add genuine tests for InfractionCollector
0120022
@theref
Add deployment script for InfractionCollector on lynx
c48f05a
@theref
Use interface for TACo Child Application in Infraction Collector
8508fd6
@theref @derekpierre
Fix deployment typo
f870094 
Co-authored-by: Derek Pierre <[email protected]>
@theref
Update README explaining how to test a deployment locally
aab8582
@theref
Add infraction deployment to child script
b44579d
@theref @cygnusv
Adding comment about transcript length
66bf256 
Co-authored-by: David Núñez <[email protected]>
@theref
Add infraction type enum for granular punishment
9774912
@theref
Decouple TACoChildApplication and infraction collector
e88941b
@theref
Move coordinator and taco application to contstructor
ac4181f
@theref
Fix bug with removing initialize
a43a0e2
@theref
Clean up README deployments
b99d3ea
@theref
Make infractionCollector constructor more robust
8cb11f5
@theref
Add InfractionReported event
988dc44
@theref
Fix tests and contract constructor
2867808
@theref
Fix logic of tests to make code more efficient
bb59916
@theref @derekpierre
Fix yaml tab/spaces
5de9946 
Co-authored-by: Derek Pierre <[email protected]>
@theref
Add new test where only half of nodes submit transcripts
d6047d7
@theref
Add PR suggestion on named mapping
ebd1e43
@theref
Deploy InfractionCollector to Lynx
1b756ee
@theref
Deploy InfractionCollector to tapir
5fff77b
@theref
Add initialize function back into InfractionCollector
c822ab5
@theref
Remove duplicated IEncryptionAuthorizer
aa07f06
@theref
Apply PR suggestions
837a388 
- Move enum
- get tacoChildApplication from Coordinator
- infractions -> infractionsForRitual and value bool -> int256
- tests readability
- replace `if` with `require`
@theref
Update Infraction tests to align with Coordinator after rebase
0246332
@theref
Copy link
Contributor

theref commented Feb 4, 2025

This has already been deployed to mainnet - https://polygonscan.com/address/0x63d2A01f006D553a2348386355f8FC3028CDf3bB

i believe the only thing blocking it is #324
I think we were waiting for the results of that to have an idea of what punishments would be handed out

@KPrasch @cygnusv

@KPrasch KPrasch self-requested a review April 13, 2025 00:59
@KPrasch KPrasch marked this pull request as ready for review April 13, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPrasch KPrasch Awaiting requested review from KPrasch

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cygnusv @theref @KPrasch