feat: end to end wiring for per message nack - #231
Merged
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Thread NackOptions from the incoming proto NackRequest through to the user-facing NackRequest interface so source implementations can inspect per-message redelivery options (delay, max deliveries, reason). Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Adds NACK sentinel tag, MessageToNack constructor, NackOptions field+getter to batchmapper.Message, and emits nack_options in the dispatch loop so per-message nack metadata flows through to the proto response. Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
vaibhavtiwari33
changed the title
vaibhavtiwari33
marked this pull request as ready for review
June 29, 2026 16:10
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
yhl25
approved these changes
Jul 3, 2026
yhl25
left a comment
yhl25
left a comment
Contributor
There was a problem hiding this comment.
Please update the examples in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219