Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: remove unused metrics in reduce UDF
The metric reduce_pnf_partitions_inflight (ReducePartitionsInFlight) had been no longer visited. This commit removes it.
doc: reduce_pbq_write_time that have not been documented in metrics
The metric reduce_pbq_write_time have been visited, but not documented yet. This commit adds it to the Metrics page.
chore: redefine ReduceForwardTime and ReduceProcessTime
There is no metric visited in reduce UDF meaning latency from an upstream ISB to a PBQ, nor from a PBQ to a downstream ISB. I'd say such metrics are useful to monitor pipeline's healthiness and performance.
The two metrics ReduceForwardTime and ReduceProcessTime have been defined but not visited. They look just right, so this commit redefines them. Now ReduceForwardTime means latency from an upstream ISB to a PBQ, and ReduceProcessTime from a PBQ to a downstream ISB.
fix: visit missing latency mertics in reduce UDF
This commit has reduce UDF visit the following metrics:
Close #2512
doc: two latency metrics not visited in reduce UDF
The metrics forwarder_udf_processing_time and forwarder_forward_chunk_processing_time are visited only in map UDF, not in reduce UDF. This commit states that.