Skip to content

gha/upgrade linux-64 manylinux image #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swap357 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gha/upgrade linux-64 manylinux image #1344

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53ea358
update manylinux image version on linux-64 wheel builder workflow
swap357 Oct 29, 2025
fb71154
set C++ ABI to match LLVM conda package in build_llvmlite.sh
swap357 Oct 29, 2025
e1d2431
add build_llvmlite.sh to pull request paths for wheel builder workflows
swap357 Oct 29, 2025
7002af7
Merge branch 'main' into gha/upgrade_linux-64_manylinux_image
swap357 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/llvmlite_linux-64_wheel_builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
pull_request:
paths:
- .github/workflows/llvmlite_linux-64_wheel_builder.yml
- buildscripts/manylinux/build_llvmlite.sh
workflow_dispatch:
inputs:
llvmdev_run_id:
Expand All @@ -25,7 +26,7 @@ env:
CONDA_CHANNEL_NUMBA: numba/label/llvm20-wheel
VALIDATION_PYTHON_VERSION: "3.12"
ARTIFACT_RETENTION_DAYS: 7
MANYLINUX_IMAGE: "manylinux2014_x86_64"
MANYLINUX_IMAGE: "manylinux_2_28_x86_64:2025.09.19-1"
Copy link
Member

@esc esc Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we need manylinux_2_28_x86_64:2025.09.19-1 explicitly or would it be ok to use just manylinux_2_28_x86_64?

Copy link
Contributor Author

@swap357 swap357 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned it to version cibuildwheel uses. The pinning is mostly so that we won't have silent or hard to trace failures. If latest image updates to a newer toolchain with ABI changes, it could error llvmlite builds or silently break numba builds.


jobs:
linux-64-build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/llvmlite_linux-aarch64_wheel_builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
pull_request:
paths:
- .github/workflows/llvmlite_linux-aarch64_wheel_builder.yml
- buildscripts/manylinux/build_llvmlite.sh
workflow_dispatch:
inputs:
llvmdev_run_id:
Expand Down
10 changes: 10 additions & 0 deletions buildscripts/manylinux/build_llvmlite.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ python setup.py clean
# Configure build via env vars
export LLVMLITE_PACKAGE_FORMAT="wheel"

# Set C++ ABI based on architecture
# x86_64 llvmdev used manylinux2014 image, which uses old ABI,
# aarch64 uses manylinux_2_28 image, which uses new ABI
# llvmlite now uses manylinux_2_28 image for both architectures, which uses new ABI
ARCH=$(uname -m)
if [ "$ARCH" = "x86_64" ]; then
# set old ABI for x86_64
export CXXFLAGS="-D_GLIBCXX_USE_CXX11_ABI=0 ${CXXFLAGS}"
Copy link
Member

@esc esc Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numba-hatchery uses this too: https://github.com/numba/numba-hatchery/blob/main/compile.sh#L50

Copy link
Contributor Author

@swap357 swap357 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I actually got it from there. The python container image we use there has similar newer GLIBC and is ABI-incompatible to GLIBC on manylinux2014 image which was used to build llvmdev.

fi

# Build wheel
distdir=$outputdir/dist_$(uname -m)_$pyver
rm -rf $distdir
Expand Down
Loading