Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plain ascii anchors to avoid problems with link checker #825

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Jan 21, 2025

@steppi I think the translated anchors were correct, but suspect the netlify link checker does not deal perfectly with unicode. I made the anchors plain text ascii to see if we can work around the issue.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 5e695f1
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/67902cabf5a2460008ce7856
😎 Deploy Preview https://deploy-preview-825--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Contributor Author

stefanv commented Jan 21, 2025

We may want to consider explicitly setting all IDs to the English anchor, so that you can navigate between languages by just changing en to pt etc. But, I'll leave it up to you to decide if that is desirable.

@agriyakhetarpal
Copy link
Contributor

Thanks!

Copy link
Member

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jarrodmillman jarrodmillman merged commit b2a8823 into numpy:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants