Fix #441 #442
Closed
Fix #441 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprouse
requested changes
Jul 24, 2018
There was a problem hiding this comment.
I agree with @CharliePoole's comments in the issue that we should have a way for extensions to do this rather than a command line option. This works, but it will require everyone who runs your tests to know the command line is needed when using your extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash bug in MasterTestRunner.Load, and provides an option to load the runner before tests are executed. This fixes issue #441.
The command line option is just one way of doing it, as I don't know what you prefer. There is certainly a change in behavior when preloading like this. It takes longer time before tests start to execute. However, I think the total work being done is the same. We can also just always do it, or create an inverted option.