Added issue 1713

nunit · Nov 19, 2023 · 198a4f9 · 198a4f9
1 parent 3fbd92c
commit 198a4f9
Show file tree

Hide file tree

Showing 19 changed files with 533 additions and 0 deletions.
diff --git a/Issue1713/.runsettings b/Issue1713/.runsettings
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- File name extension must be .runsettings -->
+<!-- For more information, see https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022  -->
+<RunSettings>
+    <RunConfiguration>
+        <!-- See https://github.com/microsoft/vstest-docs/blob/master/docs/configure.md -->
+        <!-- 1. Test related settings -->
+        <!-- [x86] | x64: architecture of test host -->
+        <!--<TargetPlatform>x86</TargetPlatform>-->
+
+        <!-- Framework35 | [Framework40] | Framework45 -->
+        <!--<TargetFrameworkVersion>Framework40</TargetFrameworkVersion>-->
+
+        <!-- Path to Test Adapters -->
+        <!--<TestAdaptersPaths>%SystemDrive%\Temp\foo;%SystemDrive%\Temp\bar</TestAdaptersPaths>-->
+        <TreatTestAdapterErrorsAsWarnings>false</TreatTestAdapterErrorsAsWarnings>
+        <!-- Path relative to solution directory -->
+        <ResultsDirectory>.\TestResults</ResultsDirectory>
+
+        <!-- 0 = As many processes as possible, limited by number of cores on machine, 1 = Sequential (1 process), 2-> Given number of processes up to limit by number of cores on machine-->
+        <MaxCpuCount>0</MaxCpuCount>
+
+        <!-- TestSessionTimeout was introduced in Visual Studio 2017 version 15.5 -->
+        <!-- Specify timeout in milliseconds. A valid value should be >= 0. If 0, timeout will be infinity-->
+        <TestSessionTimeout>10000</TestSessionTimeout>
+
+        <!-- Specify a Boolean value, which defines the exit code when no tests are discovered.-->
+        <TreatNoTestsAsError>false</TreatNoTestsAsError>
+
+        <!-- STA | MTA  default is STA for .NET Full and MTA for .NET Core-->
+        <!--<ExecutionThreadApartmentState>STA</ExecutionThreadApartmentState>-->
+
+        <!-- Disables in-assembly parallel execution, applies to both MSTest and NUnit -->
+        <DisableParallelization>false</DisableParallelization>
+        <DisableAppDomain>false</DisableAppDomain>
+        <CollectSourceInformation>true</CollectSourceInformation>
+
+        <!-- Runner related configuration -->
+        <BatchSize>10</BatchSize>
+
+    </RunConfiguration>
+
+    <!--
+  <TestRunParameters>
+    <Parameter name="webAppUrl" value="http://localhost" />
+    <Parameter name="webAppUserName" value="Admin" />
+  </TestRunParameters>
+  -->
+
+    <!--  Section for loggers,  see https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#loggerrunsettings-element 
+  <LoggerRunSettings>
+      <Loggers>
+        <Logger friendlyName="console" enabled="True">
+          <Configuration>
+              <Verbosity>quiet</Verbosity>
+          </Configuration>
+        </Logger>
+        <Logger friendlyName="trx" enabled="True">
+          <Configuration>
+            <LogFileName>foo.trx</LogFileName>
+          </Configuration>
+        </Logger>
+        <Logger friendlyName="html" enabled="True">
+          <Configuration>
+            <LogFileName>foo.html</LogFileName>
+          </Configuration>
+        </Logger>
+      </Loggers>
+    </LoggerRunSettings>
+-->
+
+
+
+
+    <!-- Adapter Specific sections -->
+
+    <!-- NUnit3 adapter, uncomment sections to set as appropriate, numeric, booleans, enums have their default values below, except RandomSeed -->
+    <!-- For documentation, see https://docs.nunit.org/articles/vs-test-adapter/Tips-And-Tricks.html -->
+    <NUnit>
+      <SkipExecutionWhenNoTests>false</SkipExecutionWhenNoTests>
+        <!--<BasePath>D:\Dev\NUnit\nunit3-vs-adapter\demo\NUnitTestDemo\bin\Release</BasePath>-->
+        <!--<PrivateBinPath>extras;more.extras</PrivateBinPath>-->
+        <DefaultTimeout>0</DefaultTimeout>
+        <!--<WorkDirectory>work</WorkDirectory>-->
+        <InternalTraceLevel>Off</InternalTraceLevel>
+        <!--<RandomSeed>1234567</RandomSeed>-->
+        <NumberOfTestWorkers>-1</NumberOfTestWorkers>
+        <Verbosity>0</Verbosity>
+        <!--<UseVsKeepEngineRunning>false</UseVsKeepEngineRunning>-->
+        <!--<ShadowCopyFiles>false</ShadowCopyFiles>-->
+        <!--<DefaultTestNamePattern>{m}{a}</DefaultTestNamePattern>-->
+        <!--<DomainUsage>Single</DomainUsage>-->
+        <DumpXmlTestDiscovery>false</DumpXmlTestDiscovery>
+        <DumpXmlTestResults>false</DumpXmlTestResults>
+        <ShowInternalProperties>false</ShowInternalProperties>
+        <!--<TestOutputXml>TestOutputXml</TestOutputXml>-->
+        <!--<Where></Where>-->
+        <!-- NUnit filter expression, see https://docs.nunit.org/articles/nunit/running-tests/Test-Selection-Language.html  -->
+        <ConsoleOut>1</ConsoleOut>
+        <UseTestNameInConsoleOutput>true</UseTestNameInConsoleOutput>
+        <StopOnError>false</StopOnError>
+        <SkipNonTestAssemblies>false</SkipNonTestAssemblies>
+        <MapWarningTo>Skipped</MapWarningTo>
+        <!--Passed, Failed or Skipped-->
+        <DisplayName>Name</DisplayName>
+        <!--Name, FullName or FullNameSep-->
+        <FullnameSeparator>:</FullnameSeparator>
+        <DiscoveryMethod>Current</DiscoveryMethod>
+        <!--Legacy or Current-->
+        <AssemblySelectLimit>2000</AssemblySelectLimit>
+        <NewOutputXmlFileForEachRun>false</NewOutputXmlFileForEachRun>
+        <IncludeStackTraceForSuites>true</IncludeStackTraceForSuites>
+        <ExplicitMode>Strict</ExplicitMode>
+        <SkipExecutionWhenNoTests>false</SkipExecutionWhenNoTests>
+    </NUnit>
+
+</RunSettings>
diff --git a/Issue1713/Dummy.cs b/Issue1713/Dummy.cs
@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Issue1713Dummy;
+
+internal class Dummy
+{
+    [Test]
+    public void DummyTest()
+    {
+        Assert.Pass();
+    }
+}
diff --git a/Issue1713/GlobalUsings.cs b/Issue1713/GlobalUsings.cs
@@ -0,0 +1 @@
+global using NUnit.Framework;
diff --git a/Issue1713/Issue1713.csproj b/Issue1713/Issue1713.csproj
@@ -0,0 +1,20 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net6.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+
+    <IsPackable>false</IsPackable>
+    <IsTestProject>true</IsTestProject>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
+    <PackageReference Include="NUnit" Version="3.14.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="4.2.0" />
+    <PackageReference Include="NUnit.Analyzers" Version="3.9.0" />
+    <PackageReference Include="coverlet.collector" Version="6.0.0" />
+  </ItemGroup>
+
+</Project>
diff --git a/Issue1713/Issue1713.sln b/Issue1713/Issue1713.sln
@@ -0,0 +1,30 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.8.34309.116
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Issue1713", "Issue1713.csproj", "{2F31D341-BEF5-4D70-A133-B2EEBD279D62}"
+EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{0DFD5A77-FA9B-4CDC-8984-0CF8C0C0BAA1}"
+	ProjectSection(SolutionItems) = preProject
+		.runsettings = .runsettings
+	EndProjectSection
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{2F31D341-BEF5-4D70-A133-B2EEBD279D62}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{2F31D341-BEF5-4D70-A133-B2EEBD279D62}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{2F31D341-BEF5-4D70-A133-B2EEBD279D62}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{2F31D341-BEF5-4D70-A133-B2EEBD279D62}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {B18C0E6D-6AEC-452B-86F2-E3151CF2AC74}
+	EndGlobalSection
+EndGlobal
diff --git a/Issue1713/README.md b/Issue1713/README.md
@@ -0,0 +1 @@
+See [Issue 1713](https://github.com/nunit/nunit/issues/1713)  and [comment there](https://github.com/nunit/nunit/issues/1713#issuecomment-1817866573) for details.
diff --git a/Issue1713/Setup.cs b/Issue1713/Setup.cs
@@ -0,0 +1,12 @@
+
+namespace Issue1713;
+
+[SetUpFixture]
+public class AssemblySetUpAndTearDown
+{
+    [OneTimeSetUp]
+    public void AssemblyInitialize()
+    {
+        throw new Exception("Didnt expect this to throw");
+    }
+}
diff --git a/Issue1713/UnitTest1.cs b/Issue1713/UnitTest1.cs
@@ -0,0 +1,11 @@
+namespace Issue1713;
+
+public class Tests
+{
+    //[Test,Category("OhNo")]
+    [Test,Explicit]
+    public void Test1()
+    {
+        Assert.Pass();
+    }
+}
diff --git a/Issue4491/Issue4491.csproj b/Issue4491/Issue4491.csproj
@@ -9,6 +9,14 @@
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <WarningLevel>9999</WarningLevel>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <WarningLevel>9999</WarningLevel>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
     <PackageReference Include="NUnit" Version="4.0.0-beta.1" />

diff --git a/Issue4491/UnitTest1.cs b/Issue4491/UnitTest1.cs
@@ -19,6 +19,7 @@ public void Test2()
         TestContext.WriteLine(TestContext.CurrentContext.Test.ID);
     }
 
+
     [Test]
     public void Test3()
     {

diff --git a/Issue4491B/.runsettings b/Issue4491B/.runsettings
@@ -0,0 +1,144 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- For more information, see https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2019  -->
+
+<RunSettings>
+  <RunConfiguration>
+    <!-- See https://github.com/microsoft/vstest-docs/blob/master/docs/configure.md -->
+    <!-- 1. Test related settings -->
+    <!-- [x86] | x64: architecture of test host -->
+    <!--<TargetPlatform>x86</TargetPlatform>-->
+
+    <!-- Framework35 | [Framework40] | Framework45 -->
+    <!--<TargetFrameworkVersion>Framework40</TargetFrameworkVersion>-->
+
+    <!-- Path to Test Adapters -->
+    <!--<TestAdaptersPaths>%SystemDrive%\Temp\foo;%SystemDrive%\Temp\bar</TestAdaptersPaths>-->
+    <TreatTestAdapterErrorsAsWarnings>false</TreatTestAdapterErrorsAsWarnings>
+
+    <!-- Path relative to solution directory -->
+    <ResultsDirectory>.\TestResults</ResultsDirectory>
+
+    <!-- 0 = As many processes as possible, limited by number of cores on machine, 1 = Sequential (1 process), 2-> Given number of processes up to limit by number of cores on machine-->
+    <MaxCpuCount>0</MaxCpuCount>
+
+    <!-- TestSessionTimeout was introduced in Visual Studio 2017 version 15.5 -->
+    <!-- Specify timeout in milliseconds. A valid value should be >= 0. If 0, timeout will be infinity-->
+    <TestSessionTimeout>10000</TestSessionTimeout>
+
+    <!-- Specify a Boolean value, which defines the exit code when no tests are discovered.-->
+    <TreatNoTestsAsError>false</TreatNoTestsAsError>
+
+    <!-- STA | MTA  default is STA for .NET Full and MTA for .NET Core-->
+    <!--<ExecutionThreadApartmentState>STA</ExecutionThreadApartmentState>-->
+
+    <!-- Disables in-assembly parallel execution, applies to both MSTest and NUnit -->
+    <DisableParallelization>false</DisableParallelization>
+    <DisableAppDomain>false</DisableAppDomain>
+    <CollectSourceInformation>true</CollectSourceInformation>
+
+    <!-- Runner related configuration -->
+    <BatchSize>10</BatchSize>
+
+  </RunConfiguration>
+
+  <!-- <DataCollectionRunSettings>
+  <DataCollectors> -->
+  <!-- This option can help you isolate a problematic test that causes a test host crash. Running the collector creates an output file (Sequence.xml) in TestResults, which captures the order of execution of the test before the crash. -->
+  <!-- See https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#blame-data-collector-->
+  <!-- <DataCollector friendlyName="blame" enabled="True"> 
+     </DataCollectors> -->
+  <!-- </DataCollectionRunSettings> -->
+
+  <!--
+    <TestRunParameters>
+        <Parameter name="webAppUrl" value="http://localhost" />
+        <Parameter name="webAppUserName" value="Admin" />
+    </TestRunParameters>  -->
+
+  <!--  Section for loggers,  see https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2019#loggerrunsettings-element 
+  <LoggerRunSettings>
+      <Loggers>
+        <Logger friendlyName="console" enabled="True">
+          <Configuration>
+              <Verbosity>quiet</Verbosity>
+          </Configuration>
+        </Logger>
+        <Logger friendlyName="trx" enabled="True">
+          <Configuration>
+            <LogFileName>foo.trx</LogFileName>
+          </Configuration>
+        </Logger>
+        <Logger friendlyName="html" enabled="True">
+          <Configuration>
+            <LogFileName>foo.html</LogFileName>
+          </Configuration>
+        </Logger>
+      </Loggers>
+    </LoggerRunSettings>
+-->
+
+
+  <!-- Adapter Specific sections -->
+
+  <!-- MSTest adapter -->
+  <MSTest>
+    <MapInconclusiveToFailed>false</MapInconclusiveToFailed>
+    <CaptureTraceOutput>true</CaptureTraceOutput>
+    <DeleteDeploymentDirectoryAfterTestRunIsComplete>true</DeleteDeploymentDirectoryAfterTestRunIsComplete>
+    <DeploymentEnabled>true</DeploymentEnabled>
+    <DeployTestSourceDependencies>true</DeployTestSourceDependencies>
+    <MapNotRunnableToFailed>false</MapNotRunnableToFailed>
+    <EnableBaseClassTestMethodsFromOtherAssemblies>false</EnableBaseClassTestMethodsFromOtherAssemblies>
+    <!-- <TestTimeout>5000</TestTimeout> -->
+
+    <!-- Uncomment and update path for assembly resolution  -->
+    <!--  <AssemblyResolution>    
+                  <Directory path="D:\myfolder\bin\" includeSubDirectories="false"/>
+             </AssemblyResolution>  -->
+    <ForcedLegacyMode>false</ForcedLegacyMode>
+    <!-- 
+           <SettingsFile>a .testsettings file (require ForcedLegacyMode true) </SettingsFile>
+        -->
+  </MSTest>
+
+  <!-- NUnit3 adapter, uncomment sections to set as appropriate, numeric, booleans, enums have their default values below, except RandomSeed -->
+  <!-- For documentation, see https://docs.nunit.org/articles/vs-test-adapter/Tips-And-Tricks.html -->
+  <NUnit>
+    <!--<BasePath>D:\Dev\NUnit\nunit3-vs-adapter\demo\NUnitTestDemo\bin\Release</BasePath>-->
+    <!--<PrivateBinPath>extras;more.extras</PrivateBinPath>-->
+    <DefaultTimeout>0</DefaultTimeout>
+    <!--<WorkDirectory>work</WorkDirectory>-->
+    <InternalTraceLevel>Off</InternalTraceLevel>
+    <!--<RandomSeed>1234567</RandomSeed>-->
+    <NumberOfTestWorkers>-1</NumberOfTestWorkers>
+    <Verbosity>0</Verbosity>
+    <!--<UseVsKeepEngineRunning>false</UseVsKeepEngineRunning>-->
+    <!--<ShadowCopyFiles>false</ShadowCopyFiles>-->
+    <!--<DefaultTestNamePattern>{m}{a}</DefaultTestNamePattern>-->
+    <!--<DomainUsage>Single</DomainUsage>-->
+    <DumpXmlTestDiscovery>false</DumpXmlTestDiscovery>
+    <DumpXmlTestResults>true</DumpXmlTestResults>
+    <ShowInternalProperties>false</ShowInternalProperties>
+    <!--<TestOutputXml>TestOutputXml</TestOutputXml>-->
+    <!--<Where></Where>-->
+    <!-- NUnit filter expression, see https://docs.nunit.org/articles/nunit/running-tests/Test-Selection-Language.html  -->
+    <ConsoleOut>1</ConsoleOut>
+    <UseTestNameInConsoleOutput>true</UseTestNameInConsoleOutput>
+    <StopOnError>false</StopOnError>
+    <SkipNonTestAssemblies>false</SkipNonTestAssemblies>
+    <MapWarningTo>Skipped</MapWarningTo>
+    <!--Passed, Failed or Skipped-->
+    <DisplayName>Name</DisplayName>
+    <!--Name, FullName or FullNameSep-->
+    <FullnameSeparator>:</FullnameSeparator>
+    <DiscoveryMethod>Current</DiscoveryMethod>
+    <!--Legacy or Current-->
+    <AssemblySelectLimit>2000</AssemblySelectLimit>
+    <NewOutputXmlFileForEachRun>true</NewOutputXmlFileForEachRun>
+    <IncludeStackTraceForSuites>true</IncludeStackTraceForSuites>
+    <ExplicitMode>Strict</ExplicitMode>
+    <SkipExecutionWhenNoTests>false</SkipExecutionWhenNoTests>
+
+  </NUnit>
+</RunSettings>
+
diff --git a/Issue4491B/GlobalUsings.cs b/Issue4491B/GlobalUsings.cs
@@ -0,0 +1 @@
+global using NUnit.Framework;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		See [Issue 1713](https://github.com/nunit/nunit/issues/1713) and [comment there](https://github.com/nunit/nunit/issues/1713#issuecomment-1817866573) for details.
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ public void Test2() @@
             TestContext.WriteLine(TestContext.CurrentContext.Test.ID);
         }
         [Test]
         public void Test3()
         {
@@ Expand Down @@