[CS2103T-T10-3] WorkBook#102
Open
rylzxc wants to merge 386 commits intonus-cs2103-AY2223S1:masterfrom
Open
Conversation
Codecov ReportBase: 72.15% // Head: 67.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
============================================
- Coverage 72.15% 67.32% -4.83%
- Complexity 399 499 +100
============================================
Files 70 87 +17
Lines 1232 1659 +427
Branches 125 181 +56
============================================
+ Hits 889 1117 +228
- Misses 311 491 +180
- Partials 32 51 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Update app version number
Let's update the acknowledgements and user stories segments to reflect what we used in developing WorkBook and the stories behind each feature respectively.
Update Developer Guide
Add use case for undo command to Developer Guide
Add Redo Command
Add redo use case and update DeveloperGuide.md
Add 3 user stories and 1 use case to DG
If one uses Find followed by Edit, the filtering resets (as if List had been used). It does not seem very user friendly and is also somewhat disruptive/jarring based on my own testing. Let's remove this behaviour, so that Edit does not reset any Predicates imposed on the internal internship list.
Let's add some util methods to DateTime and use them in our custom InternshipComparator. Note the checks for `DateTime.EMPTY_DATETIME` in the comparator. Comparison will follow the ordering as specified in the Developer Guide.
Note the minor fix in `InternshipComparator.java`. Originally the comparison would be wrong if `o1` was a upcoming date and `o2` was a date that had passed already.
Let's use better dates (upcoming, past, blank) so that new users can actually get an idea of the enforced sorting in WorkBook.
Failing test cases exposed another weakness in the InternshipComparator. A desirable characteristic of our comparator (especially for testing) is unambiguity, so let's further specify how we want two empty datetimes to be sorted - by lexicographical order of Company name. Also, we have to fix the `equals` method on UniqueInternshipList.java as equality should only be checked w.r.t the sorted list and not the internal list as that is the external facing interface anyway. This fixes all the remaining test cases that were failing.
Let's update `Stage` to include checks for those with curated tips. In this manner, frontend can call this method to determine if the input stage has tips to display.
Let's notify the user if they added a stage that was not prepared beforehand by us. If it is something related, they can easily edit the stage to suit our pre-defined list and get some tips. This encourages flexibility for the user, instead of outwright rejection. Testcases are not updated as of this commit.
Fix naming convention and testing
Fix PPP bugs
Fix PPP typos
Fix css resource file not found error
Delete extra line in PPP
Improve code quality
Remove gif from UG
Hotfix for UG
Add Acknowledgements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkBook is a desktop app for CS/tech students who are applying for internships to manage their internship applications, optimized for use via a Command Line Interface while still having the benefits of a Graphical User Interface (GUI). If you can type fast, WB can get your internship management tasks done faster than traditional GUI apps.