Skip to content

Translated "Reedline, Nu''s line editor" (PT-BR) #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 14, 2024

Conversation

me15degrees
Copy link
Contributor

No description provided.

@hustcer
Copy link
Contributor

hustcer commented Jan 10, 2024

Thanks and the CI building failure need to be fixed before landing

...
}
```
**Edit this page on <a href=https://github.com/nushell/nushell.github.io/edit/main/book/line_editor.md>GitHub**</a>
Copy link
Contributor

@hustcer hustcer Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that broken the CI, could be changed to **Edit this page on [GitHub](https://github.com/nushell/nushell.github.io/edit/main/book/line_editor.md)**
BTW: I think this line and the following line could be removed

Copy link
Contributor

@hustcer hustcer Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to leave the file name unchanged after translation, and update the i18n-meta.json file at the same time, The translation guid could be found here: https://github.com/nushell/nushell.github.io/blob/main/CONTRIBUTING.md#translation-guide

@hustcer
Copy link
Contributor

hustcer commented Jan 14, 2024

Thanks, let's landing it

@hustcer hustcer merged commit a254ba8 into nushell:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants