Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grammar to nushell 0.98.0, version and changelog #188

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .eslintignore

This file was deleted.

22 changes: 9 additions & 13 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
/**@type {import('eslint').Linter.Config} */
// eslint-disable-next-line no-undef
// .eslintrc.js
module.exports = {
root: true,
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint'],
extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended'],
rules: {
semi: [2, 'always'],
'@typescript-eslint/no-unused-vars': 0,
'@typescript-eslint/no-explicit-any': 0,
'@typescript-eslint/explicit-module-boundary-types': 0,
'@typescript-eslint/no-non-null-assertion': 0,
},
// ...other config
ignorePatterns: [
'node_modules/**',
'client/node_modules/**',
'client/out/**',
'server/node_modules/**',
'server/out/**',
],
};
Empty file added .eslintrc.json
Empty file.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,3 +167,7 @@ All notable changes to the "vscode-nushell-lang" extension will be documented in
- Add spread to syntax highlighting [#174](https://github.com/nushell/vscode-nushell-lang/pull/174)
- fix markdown formatting for hover lsp [#175](https://github.com/nushell/vscode-nushell-lang/pull/175)
- update grammar for nushell 0.91.0 [#177](https://github.com/nushell/vscode-nushell-lang/pull/177)
- 1.10.0
- Remove / and \ from wordPattern [#186](https://github.com/nushell/vscode-nushell-lang/pull/186)
- Add support for def my-function syntax highlighting and add tests to it [#182](https://github.com/nushell/vscode-nushell-lang/pull/182)
- add prettier to dev deps [#181](https://github.com/nushell/vscode-nushell-lang/pull/181)
4 changes: 2 additions & 2 deletions building.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ TIL - VSCode uses regexes for language syntax highlighting in \*.tmLanguage.json
glcraft wrote a fancy program to create regexes for the extension. Here's the steps to use it.

1. clone and cargo install the tool. https://github.com/glcraft/list-to-tree
2. on windows create a set of commands. `scope commands | where is_builtin == true and is_custom == false | get name | to text | save win-cmds_20230919.txt`
3. on linux create a set of commands. `scope commands | where is_builtin == true and is_custom == false | get name | to text | save lin-cmds_20230919.txt`
2. on windows create a set of commands. `scope commands | where type == built-in or type == keyword or type == plugin | get name | to text | save win-cmds_20240923.txt`
3. on linux create a set of commands. `scope commands | where type == built-in or type == keyword or type == plugin | get name | to text | save lin-cmds_20240923.txt`
4. combine these two files, sort, and uniq them. `open win-cmds_20230919.txt | lines | append (open lin-cmds_20230919.txt | lines) | sort | uniq | save cmds_20230919.txt`
5. run list-to-tree `list-to-tree --input cmds_20230919.txt --format regex`
6. copy-n-paste the results to the `nushell.tmLanguage.json` file in the appropriate place (search for "list-to-tree"). Be careful, this can be tricky.
Expand Down
5 changes: 3 additions & 2 deletions client/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import * as path from 'path';
// import { workspace, ExtensionContext } from "vscode";
import * as vscode from 'vscode';
import * as which from 'which';

import {
LanguageClient,
Expand All @@ -24,8 +25,8 @@ export function activate(context: vscode.ExtensionContext) {
provideTerminalProfile(
token: vscode.CancellationToken,
): vscode.ProviderResult<vscode.TerminalProfile> {
const which = require('which');
const path = require('path');
// const which = require('which');
// const path = require('path');

const PATH_FROM_ENV = process.env['PATH'];
const pathsToCheck = [
Expand Down
Loading
Loading