Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vulnerabilities detected by npm audit #193

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

LoicRiegel
Copy link
Contributor

Problem

When running npm install or npm audit, we get
Found three vulnerabilities (1 low, 1 medium, 1 high)

Fix

So I tried to fix it: I ran npm audit fix from the package's root, from client/ and server/. npm 10.9.2.

I'm not used to working with npm though, so let me know if this was the right way!

Now when you npm install, you get 0 vulnerabilities.

I just launched the extension with VS code debugging, it works. But I couldn't run the test, I'll open another PR for that

@fdncred
Copy link
Contributor

fdncred commented Mar 15, 2025

This is probably right but I want to look closer at it since so much changed.

@LoicRiegel
Copy link
Contributor Author

This is probably right but I want to look closer at it since so much changed.

Yes of course

@fdncred fdncred merged commit 7c14c04 into nushell:main Mar 24, 2025
1 check passed
@fdncred
Copy link
Contributor

fdncred commented Mar 24, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants