Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #194

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Add CONTRIBUTING.md #194

merged 5 commits into from
Mar 24, 2025

Conversation

LoicRiegel
Copy link
Contributor

Still in draft, because I want to add instructions for how to run tests

For me it didn't work
image

Only the src dir is included in vscode-nushell-lang\client\out. This makes sense because it's configured that way

// tsconfig.json
  "include": ["src"],

Can anyone help? Or should I open an issue?

@LoicRiegel LoicRiegel changed the title Add CONTRIBUTING.md [Feedback needed] Add CONTRIBUTING.md Mar 11, 2025
@fdncred
Copy link
Contributor

fdncred commented Mar 15, 2025

I'm not sure. You might look how other repos do this type of testing.

@LoicRiegel LoicRiegel changed the title [Feedback needed] Add CONTRIBUTING.md Add CONTRIBUTING.md Mar 15, 2025
@LoicRiegel
Copy link
Contributor Author

I'm not sure. You might look how other repos do this type of testing.

Okay, please tell me if the current changes can already be merged, if I add testing I'll do that in another PR.

For now:

  • I removed a dead file (it was entirely commented out)
  • renamed building.md -> CONTRIBUTING.md. When I started contributing here I didn't immediately see this file, but I would have if it was named CONTRIBUTING.md.

@LoicRiegel LoicRiegel marked this pull request as ready for review March 15, 2025 14:19
@fdncred
Copy link
Contributor

fdncred commented Mar 24, 2025

good enough i think. i reference that deleted file sometimes but it's probably good enough to delete it. thanks

@fdncred fdncred merged commit 16446cd into nushell:main Mar 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants