Skip to content

[Draft] version 0.5 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

[Draft] version 0.5 #135

wants to merge 81 commits into from

Conversation

Akeit0
Copy link
Collaborator

@Akeit0 Akeit0 commented Apr 27, 2025

Many API changes.
Pass more tests!
image

@Akeit0 Akeit0 requested a review from nuskey8 April 29, 2025 13:26
@Akeit0
Copy link
Collaborator Author

Akeit0 commented Apr 29, 2025

@nuskey8
The basic structure is done, but I'd like to see API adjustments, etc.
If you follow the steps from ConsoleApp2, it should be easy to understand for now.

@nuskey8
Copy link
Owner

nuskey8 commented Apr 30, 2025

I'm currently working on another project, so I'll review it soon.

One thing is that the Lua.CodeAnalysis API has been removed, but I would like to keep it because it's simply useful for analyzing Lua syntax trees.

@marchc1
Copy link

marchc1 commented May 6, 2025

As I mentioned in #134; here's a couple other issues I noticed while developing my project. I'm on Nuget version 0.4.2. These are just invalid Lua syntax still compiling issues, though.

  • Trailing commas don't throw compile errors
    Image

  • Commas missing after a key = value expression in a table don't cause errors?
    Image

Sorry if these are already resolved, just wanted to put them on the radar if they aren't (and I can make separate issues for them if they are already resolved, but I didn't want to pollute things with issues already fixed)

@Akeit0
Copy link
Collaborator Author

Akeit0 commented May 6, 2025

@marchc1
Both issues have been resolved.
I have completely rewritten the compiler based on implementations of lua and go-lua, so this pre-PR issue is no longer relevant. Of course there may be new issues, but they will be very few.

@Akeit0
Copy link
Collaborator Author

Akeit0 commented May 10, 2025

@CodeSmile-0000011110110111

In case this is related, I have been looking for ways to pass arguments to DoString/DoFile. The Lua way is to use load/loadfile apparently but I need to do so from C# and there currently is just no clean way to do so. Should I open a feature issue for this or have I overlooked something?

Currently, we do not have that functionality and will add it in v0.5.
(Edit: use Load(source).Invoke() like something)

Akeit0 added 25 commits May 10, 2025 21:41
change: move apis to LuaThreadAccess to validate context
Improved cancellation process and avoidance of infinite loops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants