Skip to content

GH-313: Layout definitions from patterns lack id property #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

GH-313: Layout definitions from patterns lack id property #314

wants to merge 1 commit into from

Conversation

nedjo
Copy link

@nedjo nedjo commented Nov 22, 2020

Fix #313: Layout definitions from patterns lack id property

David-Czinege
David-Czinege approved these changes Nov 6, 2021
View reviewed changes
Copy link

@David-Czinege David-Czinege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this fix and I approve that this works.

I found this ID missing issue, when I wanted to use the styleguide and the ui_patterns_layouts contrib modules together. With this fix, the style guide page is loaded as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@David-Czinege David-Czinege David-Czinege approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout definitions from patterns lack id property
2 participants
@nedjo @David-Czinege