Skip to content

Add Apollo federation support to GraphQL implementation #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

renepardon
Copy link

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated CHANGELOG.md

Resolves #911

Changes

Implementation of federation specification as described here:

Breaking changes

@renepardon
Copy link
Author

Currently blocked by webonyx/graphql-php#552 as it is not an option to copy the SchemaPrinter into lighthouse just to "extend" it.

@jerredhurst
Copy link

@spawnia - Is there a way to help in webonyx/graphql-php#552 so this can keep moving forward?

@spawnia
Copy link
Collaborator

spawnia commented Nov 27, 2019

@jerredhurst my favorite approach would be to add an option to their printer to print directives.

If that is not possible, we can go ahead and implement the simplest possible approach to solve our specific use case. Maybe we can find a way to make the SchemaPrinter extensible enough so we can reuse some of its logic?

@jerredhurst
Copy link

@spawnia - Thank you for the response. In regards to your comment:

my favorite approach would be to add an option to their printer to print directives.

Have you implemented this in other cases? Is there something we can see?

# Conflicts:
#	src/lighthouse.php
@spawnia
Copy link
Collaborator

spawnia commented Jan 30, 2020

@renepardon thanks for the effort, too bad you moved on.

Closing this PR, i pulled in the changes to a branch: https://github.com/nuwave/lighthouse/tree/federation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Apollo Federation
3 participants