fix(tiptap): match camelCase meta props to kebab-cased stored attrs#531
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
hendrikheil
force-pushed
the
worktree-idempotent-wishing-feather
branch
from
ee6961b to
b49cb66
Compare
Stored node attrs may use whatever casing the source markdown/parser produced, while nuxt-component-meta always declares props in camelCase, so compare both forms via kebabCase to bind a component's declared prop to its stored value regardless of casing.
hendrikheil
force-pushed
the
worktree-idempotent-wishing-feather
branch
from
b49cb66 to
1ff4c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #529 - Studio was corrupting MDC component props (duplicate fields in the props editor, values silently dropped/rewritten).
Root cause: the MDC parser stores component props in kebab-case (e.g.
cite-name), whilenuxt-component-metadeclares them in camelCase (e.g.citeName).buildFormTreeFromPropsinsrc/app/src/utils/tiptap/props.tsmatched these with exact string equality: