-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix build-head size failure for forks #705
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage ? 13.33%
=======================================
Files ? 66
Lines ? 3351
Branches ? 95
=======================================
Hits ? 447
Misses ? 2873
Partials ? 31 β View full report in Codecov by Sentry. |
commit: |
577a44f
to
fb88def
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you πβ€οΈ
oops. too hasty an approval. still, thank you for looking at this |
THanks @danielroe , i am tring to see why the compare is failing, looks like it is relative to permisison/fork too, i am investigating that |
@danielroe i've tried one hour long all the things to find out why it was not working... even tho i was wondering if it is related to the fork, i saw some olders PR (weeks not that much) that the check passed. |
thank you! if you're happy to leave this PR open, I can experiment a bit with it |
@danielroe for sure, feel free to play around with it |
1641a70
to
ec73171
Compare
I did some testing and looks like when changing from |
@danielroe sorry i wrote it wrong, by:
i mean on the yml of the main branch here https://github.com/nuxt/cli/blob/main/.github/workflows/size.yml |
π Linked issue
Not a related issue but this state of Dan about the failure of the build-head from size for forks
#702 (comment)
β Type of change
π Description
Adding
repository: ${{ github.event.pull_request.head.repo.full_name }}
to comparate build size for forked branchs tooFrom actions/checkout#551