-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set up non-default ipx
providers if options.ipx
is set
#1618
Conversation
Previously, specifying a custom provider would prevent setup of ipx
Co-authored-by: Daniel Roe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
==========================================
- Coverage 62.93% 62.83% -0.10%
==========================================
Files 79 79
Lines 3529 3536 +7
Branches 407 411 +4
==========================================
+ Hits 2221 2222 +1
- Misses 1279 1285 +6
Partials 29 29 β View full report in Codecov by Sentry. |
Pushed a slight refactor - does that still work for you? |
Seems fine? I couldn't quite figure out what ipxStatic did or make it work myself β though it does seem to require the ipx initialization, so if you wanted to use it alongside another default, your change would make it impossible. |
|
ipx
providers
ipx
providersipx
providers if options.ipx
is set
Fixes #1414
β Type of change
π Description
Previously, specifying a custom provider would prevent setup of ipx, which happens in a
'nitro:init
hook. That is, there was no way use ipx if it wasn't your default provider.Now, you just need to add
ipx
to the image options: