fix: deduplicate formats
#2038
Open
fix: deduplicate formats
#2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2038 +/- ##
========================================
- Coverage 6.99% 6.99% -0.01%
========================================
Files 78 78
Lines 3629 3632 +3
Branches 140 140
========================================
Hits 254 254
- Misses 3326 3329 +3
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
changed the title
formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed a small bug where webp sources were showing up twice inside NuxtPicture if you explicitly added them to your config (it was merging with the defaults and doubling up).
Quick question:
I also thought about just removing the webp default entirely if the user provides a custom config, but I wasn't sure if that would be considered a breaking change. Let me know if you think that's a cleaner path!