fix(Modal): button side-effects when used within a button group #3138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #2978
β Type of change
π Description
Fixes side-effects on button components in a modal which are rendered as if they are in a ButtonGroup if the modal is within a ButtonGroup.
The solution here is to override Button's group injection key in the Modal component. This is not ideal but solves the issue. A better solution could be to update the button groups style to only affect direct childs (https://github.com/nuxt/ui/blob/v3/src/theme/button-group.ts#L1).
π Checklist