Skip to content

fix(NavigationMenu): standardising slot name #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Apr 23, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Standardising NavigationMenu slots name with other components

  • list-leading => content-top
  • list-trailing => content-bottom

Should we do it aswell for Tabs component?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Apr 23, 2025

npm i https://pkg.pr.new/@nuxt/ui@3961

commit: 34fde47

@benjamincanac
Copy link
Member

No this is intended, the content-top and content-bottom slots are used inside a Content component but its not the same for NavigationMenu and Tabs components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants