fix(FormField): resolve minor accessibility and rendering issues #4515
+80
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
romhml
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Thanks @ThiloHettmer :)
Could you add a few test cases to lock these in? https://github.com/nuxt/ui/blob/v3/test/components/FormField.spec.ts#L108
|
Hi @romhml :) I have added 2 tests |
romhml
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
This PR fixes two minor issues. First one is that in the Formfield component the help text has no id, and the Input component references it through useFormfield by its aria-describedby. Second issue is that the aria-describedby is added even if no help text is provided to the Formfield component.