Skip to content

Make duration of indentation beeps configurable (#19353)#20447

Open
Mubashir78 wants to merge 2 commits into
nvaccess:masterfrom
Mubashir78:fix/19353-indent-tone-duration-config
Open

Make duration of indentation beeps configurable (#19353)#20447
Mubashir78 wants to merge 2 commits into
nvaccess:masterfrom
Mubashir78:fix/19353-indent-tone-duration-config

Conversation

@Mubashir78

Copy link
Copy Markdown

Fixes #19353

Description of the change

Exposes indentToneDuration (already defined in configSpec.py with min=10, max=2000, default=40) as a spin control in the Document Formatting settings panel.

The spin control is enabled only when the line indentation reporting mode includes tones (TONES or SPEECH_AND_TONES), and disabled otherwise.

Testing

  • Verified the spin control loads with the current config value (default 40)
  • Verified the spin control enables/disables correctly when switching the line indentation reporting combo
  • Verified the value is saved via onSave

@Mubashir78 Mubashir78 requested a review from a team as a code owner July 5, 2026 13:35
@Mubashir78 Mubashir78 requested a review from seanbudd July 5, 2026 13:35
@CyrilleB79

Copy link
Copy Markdown
Contributor

You have unrelated commits here, e.g. commit from (#20159).

…19353)

Adds an 'Indent tone duration (ms)' spin control (10-2000 ms) to the
Document Formatting settings panel, enabling users to adjust the
length of indentation beeps instead of using the hardcoded 40ms default.

The control is enabled only when 'Tones' or 'Speech and Tones' is
selected in the line indentation reporting combo box.
@Mubashir78 Mubashir78 force-pushed the fix/19353-indent-tone-duration-config branch from 5e2b455 to 460e8c9 Compare July 5, 2026 20:55
@Mubashir78

Copy link
Copy Markdown
Author

Thanks, rebased onto master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make duration of indentation beeps configurable

2 participants