fix: add dependencies on windows #11
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue encountered on Windows where plenary fails to execute
.bat
or.cmd
executables. On Windows, these file types require the use ofcmd /C
orpowershell -Command
to be executed correctly, but plenary was not accounting for this.Error Message:
Fix
To address this, I modified the execution of commands on Windows to use
cmd /C
. This ensures that.bat
and.cmd
files are executed correctly, resolving the issue.