fix(#820): Illegal character in filename #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, thanks for your contribution. |
craigmac
pushed a commit
to craigmac/lualine.nvim
that referenced
this pull request
May 15, 2024
* fix(nvim-lualine#820): handle % in path * fix merge issues --------- merged alongside f76d9b6 Co-authored-by: Shadman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ran into this issue with the
jdt://URLs, as reported in #820. Instead of using JDT-specific workarounds like #1030 and #821, let's fix the root cause.Given a directory structure like
%dir1/%dir2/%actual_%file', the shortening process should eliminate the%escaping. It currently shortens it to%/%/%%actual_%%file'instead of the correct '%%/%%/%%actual_%%file'. The unescaped%/is an illegal char sequence.To address this, it would make sense to run the escaping after shortening has been completed.