fix: set option to nil if not cached and set by lualine #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sam-programs
changed the title
|
I don't think if an option isn't set by us we should touch it when it's being restored. This should probably be fixed on Goyo so it properly hides and unhides lualine. We could probably throw a user even when lualine is being hidden or unhidden. But I haven't seen interest in something like that yet. So probably not necessary for now. Thanks for looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nvim-lualine/lualine.nvim/blob/master/lua/lualine.lua#L567
This line doesn't restore the global 'winbar', because lualine never sets the global 'winbar'.
I am not sure why but Goyo's window uses the global winbar option,and lualine not setting global winbar causes the winbar to stay in Goyo.
fixes(#1122)