fix: Location component was showing wrong column with inlay hints. #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location component had been previously changed to use `vim.api.virtcol` (the screen position of the cursor) instead of `vim.api.col` (the byte position of the cursor), in order to prevent showing the wrong column when multibyte characters are present. Unfortunately, the new inlay hints in neovim 0.10 make heavy use of virtual text, and therefore the column shown in the location component is often incorrect. This change fixes it to use `vim.api.charcol`, which correctly handles variable-width characters without including virtual text.
|
Thanks for the fix |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location component had been previously changed to use
vim.api.virtcol(the screen position of the cursor) instead ofvim.api.col(the byte position of the cursor), in order to preventshowing the wrong column when multibyte characters are present.
Unfortunately, the new inlay hints in neovim 0.10 make heavy use of
virtual text, and therefore the column shown in the location component
is often incorrect.
This change fixes it to use
vim.api.charcol, which correctly handlesvariable-width characters without including virtual text.