Deprecated function in example evil_lualine.lua #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
iton0
reviewed
May 26, 2024
| @@ -160,7 +160,7 @@ ins_left { | |||
| function() | |||
| local msg = 'No Active Lsp' | |||
| local buf_ft = vim.api.nvim_buf_get_option(0, 'filetype') | |||
There was a problem hiding this comment.
vim.api.nvim_buf_get_option is also deprecated with nvim 0.10.
I believe that local buf_ft = vim.api.nvim_get_option_value('filetype', {}) should be used instead
There was a problem hiding this comment.
For better readability and be more specific defining the buffer, we can use local buf_ft = vim.api.nvim_get_option_value('filetype', { 'buf': 0 }), no?
The scope option it's not necessary because by default the use of buf implies {scope} is local.
Here is the documentation
There was a problem hiding this comment.
Yeah the only adjustment is instead of 'buf' : 0 it should be buf = 0
yaotutu
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the example of evil_line.lua, show the following error:
In neovim 0.12 vim.lsp.get_active_clients() function will be deprecated, vim.lsp.get_clients() solve the problem and works perfectly