feat: carry the PostageStamp batch events from the wire to the domain - #848
Merged
Conversation
sol! declares BatchCreated, BatchTopUp and BatchDepthIncrease on IPostageStamp, matching the field names, order and types of upstream ethersphere/storage-incentives (master c8686806) and of the IPostageStamp events pinned in go-storage-incentives-abi v0.9.4; the topic hashes and the decoder field shapes are guarded by vectors in crates/contracts. The domain BatchEvent carries the normalised balance (new_value) and, for depth increases, the mined-in block. nectar-postage-issuer (std only) translates the decoded logs to BatchEvent and classifies the validation failures as the permanent EventError. AI Assistance: opencode (qwen3.8) used for the implementation and verification. Signed-off-by: mfw78 <mfw78@nxm.rs>
mfw78
force-pushed
the
feat/791-sol-events
branch
from
August 21, 2026 10:57
5f8f491 to
92b04dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Carry the PostageStamp batch events (BatchCreated, BatchTopUp, BatchDepthIncrease) from the contract wire into the domain BatchEvent, and give the issuer the translation.
Changes
Breaking changes
The domain BatchEvent variants change shape (struct variants, new new_value and block fields). nectar is pre-1.0 and the variants were internal to this tree.
Testing
Related issues
AI assistance disclosure
AI Assistance: opencode (qwen3.8) used for the implementation and verification.
Notes for reviewers
Checklist
Closes