Migrate to dispatch2, decomission nym-apple-dispatch #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
force-pushed
the
am/back-to-dispatch2
branch
5 times, most recently
from
783d344 to
42f5c4b
Compare
octol
approved these changes
Apr 11, 2025
octol
requested changes
Apr 11, 2025
rokas-ambrazevicius
approved these changes
Apr 11, 2025
pronebird
force-pushed
the
am/back-to-dispatch2
branch
from
5e2b521 to
c50e4bc
Compare
|
@octol addressed that |
octol
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the improvements in madsmtm/objc2#681 have been fully absorbed (and beyond), we can switch to using
dispatch2and decomissionnym-apple-dispatch. This improvement not only removes our own bindings tolibdispatchbut also improves dependency tree asdispatch2is used across all otherobjc2-*crates.Unfortunately, there is no official release yet for that so this PR anchors relevant crates to the commit hash.
This change is