Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of fill-tail in Block.of-inline to true #48

Closed
wants to merge 1 commit into from
Closed

Change the default value of fill-tail in Block.of-inline to true #48

wants to merge 1 commit into from

Conversation

zeptometer
Copy link
Collaborator

This closes #47

@zeptometer zeptometer requested a review from nyuichi February 16, 2020 01:31
@nyuichi
Copy link
Owner

nyuichi commented Feb 16, 2020

LGTM for the changes.
But can you reopen a pr towards a new branch called dev-2.0.0?
(Which I am going to use for collecting changes for v2.0.0)
This pr should break the existing programs so we should postpone this until the next major version is released.

@nyuichi
Copy link
Owner

nyuichi commented Feb 16, 2020

BTW it’s conflicting

@zeptometer
Copy link
Collaborator Author

Gotcha 👍

@zeptometer zeptometer closed this Apr 5, 2020
@zeptometer
Copy link
Collaborator Author

Created new PR #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyuichi nyuichi Awaiting requested review from nyuichi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the default value of fill-tail in Block.of-inline to true
2 participants
@zeptometer @nyuichi