Fix lagrange basis functions for web environments #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add caml_fp_srs_get_lagrange_basis_ptr: Returns pointer for web worker communication - Add caml_fp_srs_get_lagrange_basis_read_from_ptr: Extracts data from pointer - Follows existing working pattern from lagrange_commitments_whole_domain functions - Enables zkProgram.compile() with cache writing in web environments - Part 1 of 2: Fp functions (Fq functions to follow)
- Add caml_fq_srs_get_lagrange_basis_ptr: Returns pointer for web worker communication - Add caml_fq_srs_get_lagrange_basis_read_from_ptr: Extracts data from pointer - Completes pair with Fp functions added in previous commit - Uses same proven pattern as existing lagrange_commitments_whole_domain functions - Part 2 of 2: Now both Fp and Fq are ready for web environments
This was referenced Sep 2, 2025
ymekuria
changed the title
querolita
previously approved these changes
Sep 11, 2025
Trivo25
reviewed
Sep 18, 2025
| @@ -320,6 +320,33 @@ pub mod fp { | |||
| }); | |||
| basis.iter().map(Into::into).collect() | |||
| } | |||
|
|
|||
| /// Web-compatible version that returns pointer for worker communication | |||
There was a problem hiding this comment.
Both ways are web compatible, it just doesn't work with our current worker implementation. For clarity, I would change this comment to something that better reflects what it does: Calculates and returns a pointer to the lagrange basis
Trivo25
reviewed
Sep 18, 2025
| @@ -400,4 +427,31 @@ pub mod fq { | |||
| }); | |||
| basis.iter().map(Into::into).collect() | |||
| } | |||
|
|
|||
| /// Web-compatible version that returns pointer for worker communication | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where
zkProgram.compile()with cache writing hangs indefinitely in web browsers. The problem was thatcaml_fp_srs_get_lagrange_basisandcaml_fq_srs_get_lagrange_basisfunctions returnWasmVectortypes that cannot be transferred over the web worker synchronization API.Changes
Added new pointer-based functions for web compatibility:
Fp Functions
caml_fp_srs_get_lagrange_basis_ptr- Returns pointer for worker communicationcaml_fp_srs_get_lagrange_basis_read_from_ptr- Extracts data from pointerFq Functions
caml_fq_srs_get_lagrange_basis_ptr- Returns pointer for worker communicationcaml_fq_srs_get_lagrange_basis_read_from_ptr- Extracts data from pointerImplementation Details
lagrange_commitments_whole_domain_ptrBox::into_raw()andBox::from_raw()for pointer managementRelated PRs
This is part 1 of 3 for the complete fix:
Files Changed
plonk-wasm/src/srs.rs- Added 4 new pointer-based functions