Skip to content

Add setup script with keeping directory structure#20

Closed
yxhamada wants to merge 1 commit intooanda:masterfrom
yxhamada:master
Closed

Add setup script with keeping directory structure#20
yxhamada wants to merge 1 commit intooanda:masterfrom
yxhamada:master

Conversation

@yxhamada
Copy link
Copy Markdown

With using previous pull request #9 as a reference, added different type of setup script without changing current directory structure.

@hootnot
Copy link
Copy Markdown
Contributor

hootnot commented Dec 24, 2015

I agree that this code should be pip installable. Pull request #9 altered the directory structure to a structure that complies with https://pythonhosted.org/an_example_pypi_project/setuptools.html . This structure allows adding unittest also.

I too had the problem with automated deployment to install the oandapy module using Ansible for my own project: oanda-trading-environment , which is pip installable from pypi: https://pypi.python.org/pypi/oanda-trading-environment/0.2.0.

The current repository does not allow to install oandapy using pip.

For this I altered the structure in a way like pull request #9 and Ansible installs oandapy from my fork with its own version number, which is not desirable.
I did not do a pull request again since request #9 wasn't merged. But I would like to see the change also, so the code can be installed as a module from the original repo with versioning controlled there.
I will make a pull request for the changes I made. This includes also the change in directory structure.

After this change installing and upgrading comes down to:
pip install git+https://github.com/oanda/oandapy

a pypi package would even be more convenient:
pip install oandapy

@hootnot hootnot mentioned this pull request Dec 24, 2015
@yxhamada yxhamada closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants