Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing groups #826

Merged
merged 33 commits into from
Dec 2, 2024
Merged

Sharing groups #826

merged 33 commits into from
Dec 2, 2024

Conversation

tschmidtb51
Copy link
Contributor

  • resolves Add Sharing Groups #705
  • add sharing_group to JSON schema
  • adapt prose to reflect sharing group changes
  • add RFC 9562 to normative references
  • add RFC 4122 to informative references
  • add mandatory test to prevent usage of Max UUID in other TLP than CLEAR (6.1.39)
  • add mandatory test to prevent usage other UUID than Max UUID in TLP:CLEAR (6.1.40)
  • add mandatory test to prevent usage of reserved names (6.1.41)
  • add mandatory test to enforce usage of sharing group names (6.1.42)
  • add rule about the relationship between sharing group ID and /document/tracking/id
  • add optional test to discourage usage of Max UUID (6.2.28)
  • add optional test to discourage usage of Nil UUID (6.2.29)
  • add optional test to discourage usage sharing group with TLP:CLEAR (6.2.30)
  • add invalid examples
  • add valid examples
  • adapt testcases list and schema
  • add suggestions for quick fixes throughout the sharing group tests
  • add guidance of size for UUIDs
  • swap date and URI to make it alphabetic amongst the "special" strings
  • convert headings into title case

@tschmidtb51
Sharing Groups
64c4af2 
- addresses parts of oasis-tcs#705
- add `sharing_group` to JSON schema
@tschmidtb51
Sharing Groups
60a460b 
- addresses parts of oasis-tcs#705
- adapt prose to reflect sharing group changes
- add RFC 9562 to normative references
- add RFC 4122 to informative references
@tschmidtb51
Sharing Groups
02ae5ba 
- addresses parts of oasis-tcs#705
- add mandatory test to prevent usage of Max UUID in other TLP than CLEAR
- add invalid examples
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
71bbbd2 
- addresses parts of oasis-tcs#705
- add mandatory test to prevent usage of reserved names
- improve wording
- add invalid examples
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
077fc24 
- addresses parts of oasis-tcs#705
- add mandatory test to prevent usage other UUID than Max UUID in TLP:CLEAR
- add invalid examples
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
3487dad 
- addresses parts of oasis-tcs#705
- swap order of 6.1.40 and 6.1.41
- adapt testfiles
@tschmidtb51
Sharing Groups
dcee34c 
- addresses parts of oasis-tcs#705
- add mandatory test to enforce usage of sharing group names
- add invalid examples
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
c027e19 
- addresses parts of oasis-tcs#705
- add additional valid examples for 6.1.41
@tschmidtb51
Sharing Groups
0d98fc4 
- addresses parts of oasis-tcs#705
- add rule about the relationship between sharing group ID and `/document/tracking/id`
@tschmidtb51
Sharing Groups
38d97ce 
- addresses parts of oasis-tcs#705
- correct link format
@tschmidtb51
Sharing Groups
34cd7ba 
- addresses parts of oasis-tcs#705
- add optional test to discourage usage of Max UUID
- add invalid example
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
025eed0 
- addresses parts of oasis-tcs#705
- add optional test to discourage usage of Nil UUID
- add invalid example
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
cc06295 
- addresses parts of oasis-tcs#705
- add optional test to discourage usage sharing group with TLP:CLEAR
- add invalid example
- add valid examples
- adapt testcases list and schema
@tschmidtb51
Sharing Groups
a7ace02 
- addresses parts of oasis-tcs#705
- add new files into bind.txt
@tschmidtb51
Sharing Groups
c3459bd 
- addresses parts of oasis-tcs#705
- add suggestions for quick fixes throughout the sharing group tests
@tschmidtb51
Sharing Groups
325ef97 
- addresses parts of oasis-tcs#705
- add guidance of size for UUIDs
- swap date and URI to make it alphabetic amongst the "special" strings
@tschmidtb51
Editorial
8d44416 
- convert headings into title case
@tschmidtb51
Editorial
33da68c 
- fix format issue
@tschmidtb51 tschmidtb51 added editor-revision already worked on in the editor revision csaf 2.1 csaf 2.1 work labels Nov 18, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen November 18, 2024 21:58
@tschmidtb51 tschmidtb51 self-assigned this Nov 18, 2024
@tschmidtb51 tschmidtb51 changed the base branch from master to editor-revision-2024-11-27 November 18, 2024 21:59
sthagen
sthagen approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will need some editorial post work when the conflicts are resolved and the change set is merged into the editorial branch.

@tschmidtb51
Copy link
Contributor Author

Pending motion: https://groups.oasis-open.org/discussion/motion-for-826

@tschmidtb51 tschmidtb51 added the motion This item has a motion pending label Nov 21, 2024
@santosomar santosomar removed the motion This item has a motion pending label Nov 27, 2024
@santosomar santosomar added the motion_passed A motion has passed label Nov 27, 2024
@santosomar
Copy link
Contributor

Dear CSAF TC Members,

The motion to accept the changes described in pull request as suggested in #826 and include it into CSAF 2.1 has passed.

tschmidtb51 and others added 13 commits December 3, 2024 00:32
@tschmidtb51
Editor Revision 2024-11-27
e20ba3b 
- update dates
- insert new revision for tracking
@tschmidtb51 @oxisto
Test 6.1.31
a8d58d5 
- addresses parts of oasis-tcs#825
- improve wording in prose

Co-authored-by: Christian Banse <[email protected]>
@tschmidtb51
Test 6.1.31
b03b348 
- addresses parts of oasis-tcs#825
- add additional valid example
@tschmidtb51 @oxisto
Rephrase word to list of words
14beb9d 
Co-authored-by: Christian Banse <[email protected]>
@tschmidtb51
Date-time
95d37cb 
- addresses parts of oasis-tcs#469
- add links to standards
- add rules regarding separator
@tschmidtb51
Date-time
9b35b83 
- addresses parts of oasis-tcs#469
- add mandatory test to check date-time rules
- add invalid example
- add valid example
@tschmidtb51
Date-time
fe86df1 
- addresses parts of oasis-tcs#469
- exclude schema test failing testfile
@tschmidtb51
Changes.csv
78023c3 
- addresses parts of oasis-tcs#768
- change changes.csv to non-quoted
- clarify wording
- add normative reference to RFC 4180
@tschmidtb51
ASCII armored OpenPGP
58565c0 
- resolves oasis-tcs#797
- add explicit statements about OpenPGP signatures and key files being ASCII armored
@tschmidtb51
Clarify Inclusion of Open Source
1f9211a 
- addresses parts of oasis-tcs#790
- add open source projects
@sthagen @tschmidtb51
Nit: lower case general terms and clarify listing
73520e9
@sthagen @tschmidtb51
Restored binding of including
bf252ef
@tschmidtb51
Date-time
6a6df78 
- addresses parts of oasis-tcs#469
- add test into bind.txt
@tschmidtb51 tschmidtb51 changed the base branch from editor-revision-2024-11-27 to master December 2, 2024 23:40
@tschmidtb51 tschmidtb51 changed the base branch from master to editor-revision-2024-11-27 December 2, 2024 23:40
@tschmidtb51
Copy link
Contributor Author

Merge branch editor-revision-2024-11-27 into the sharing-groups.

@tschmidtb51 tschmidtb51 merged commit a7ef22e into oasis-tcs:editor-revision-2024-11-27 Dec 2, 2024
5 checks passed
@sthagen sthagen mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

@santosomar santosomar santosomar approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision motion_passed A motion has passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sharing Groups
3 participants
@tschmidtb51 @santosomar @sthagen