initial code - #1
Merged
Merged
Conversation
rube-de
force-pushed
the
rube/inital-paymaster-code
branch
5 times, most recently
from
September 16, 2025 17:28
b155ea2 to
ad3291e
Compare
tjanez
reviewed
Sep 16, 2025
rube-de
force-pushed
the
rube/inital-paymaster-code
branch
from
September 17, 2025 14:05
ad3291e to
3eafc49
Compare
matevz
approved these changes
Sep 23, 2025
matevz
left a comment
matevz
left a comment
Member
There was a problem hiding this comment.
IMO this can be merged. There will be a lot of followup PRs, but it's a good start.
| **Paymaster on Sapphire:** | ||
|
|
||
| ```bash | ||
| make contracts-deploy-paymaster NETWORK=sapphire-testnet ARGS="--owner 0x... --oracle 0x... --shoyubashi 0x..." |
Member
There was a problem hiding this comment.
This is probably hashi terminology. But would be good if you mention what is owner, oracle and shoyubashi here. Or point to the docs where they describe it.
Member
There was a problem hiding this comment.
I'd rather compile ABIs from source instead of putting them here.
rube-de
force-pushed
the
rube/inital-paymaster-code
branch
2 times, most recently
from
September 24, 2025 17:52
986f391 to
4031d54
Compare
rube-de
force-pushed
the
rube/inital-paymaster-code
branch
from
September 24, 2025 18:01
4031d54 to
90e1bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contracts
paymaster relayer